Skip to content

api: replace the executor client on any transport error - #29

Merged
EnzinoBB merged 1 commit into
masterfrom
fix/executor-client-recreate
Oct 13, 2026
Merged

EnzinoBB merged 1 commit into
masterfrom
fix/executor-client-recreate

Conversation

@EnzinoBB

Copy link
Copy Markdown
Collaborator

The Thrift concurrent client marks itself bad (stop_ set for good) on any
receive error, but the node replaced it only on NOT_OPEN, that is when the
next call had already failed. One timeout or dropped connection therefore
failed the following contract call too, on this node only, and a late reply
to a timed-out call could still arrive on the old connection. Replace the
client on every TTransportException; the watcher reconnects as before.

Testing

  • Local: nodetests 138/138 with all phase-1 node fixes merged together.
  • Testnet run 38374856915, branch test/phase1-combined (all node fixes) with mixed executors (executor_ref=test/compatible-fixes): 17 of 17 contract calls returned the expected value across the restart test, Counter and Ledger states equal on all 7 nodes, state digests equal up to sequence 1100.

Compatible: no result of a valid contract call changes, so nodes can adopt it one by one.

🤖 Generated with Claude Code

The Thrift concurrent client marks itself bad (stop_ set for good) on any
receive error, but the node replaced it only on NOT_OPEN, that is when the
next call had already failed. One timeout or dropped connection therefore
failed the following contract call too, on this node only, and a late reply
to a timed-out call could still arrive on the old connection. Replace the
client on every TTransportException; the watcher reconnects as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@EnzinoBB
EnzinoBB merged commit 570c8d7 into master Oct 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant